This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Add apcu compatibility #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Check/ApcFragmentation.php
Outdated
| @@ -90,11 +90,12 @@ public function check() | |||
| return new Skip('APC has not been enabled in CLI.'); | |||
| } | |||
|
|
|||
| if (! function_exists('apc_sma_info')) { | |||
| $memoryAllocationMethod = \PHP_VERSION_ID < 70000 ? 'apc_sma_info' : 'apcu_sma_info'; | |||
There was a problem hiding this comment.
In attempting to test this on PHP 5.6, I discovered that APC cannot compile against PHP 5.5 and later! Since this project only supports 5.6 and up, we can check here for only existence of the APCu extension. I'll make that change during merge.
Add apcu compatibility Conflicts: CHANGELOG.md
weierophinney
added a commit
that referenced
this pull request
Jul 30, 2018
|
Thanks, @Spea! |
|
You're welcome, thanks for merging this so quickly :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to use the APC fragmentation/memory checks, but since we use
apcuI always received the errorAPC extension is not available, thus I added a version check and based on that I use the correct method (apc_sma_infovsapcu_sma_info).