Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

Implement USE INDEX/FORCE INDEX for MySQL #489

Closed
tsmgeek opened this issue Jan 9, 2015 · 4 comments
Closed

Implement USE INDEX/FORCE INDEX for MySQL #489

tsmgeek opened this issue Jan 9, 2015 · 4 comments

Comments

@tsmgeek
Copy link

tsmgeek commented Jan 9, 2015

There was a ZF1 ticket http://framework.zend.com/issues/browse/ZF-7570 that was a request to implement USE INDEX/FORCE INDEX in the Zend_Db_Select class.

It seems that this user implemented it directly within the main Zend_Db_Select class without any abstraction to the Adapters, would this have been incorrect?

If it was re-factored into such and CLA provided could it be implemented?

@froschdesign
Copy link
Member

If it was re-factored into such and CLA provided could it be implemented?

The answer is quite simple: No unit tests == no implementation.
(Btw. At this point we do not add new features to version 1. ZF2 is the right target for that.)

@tsmgeek
Copy link
Author

tsmgeek commented Jan 9, 2015

Shame as it would be very useful for some users of ZF1 as re-factoring to ZF2 for many is too much.

@froschdesign
Copy link
Member

Shame…

Why?

I extend my answer: At this point we (usually) do not add new features to version 1.
So create a PR with (!) unit tests and we will review it. Unit tests are always needed.

@froschdesign
Copy link
Member

Closing due inactivity.

Please feel free to send a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants