You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 16, 2018. It is now read-only.
It seems that this user implemented it directly within the main Zend_Db_Select class without any abstraction to the Adapters, would this have been incorrect?
If it was re-factored into such and CLA provided could it be implemented?
The text was updated successfully, but these errors were encountered:
If it was re-factored into such and CLA provided could it be implemented?
The answer is quite simple: No unit tests == no implementation.
(Btw. At this point we do not add new features to version 1. ZF2 is the right target for that.)
I extend my answer: At this point we (usually) do not add new features to version 1.
So create a PR with (!) unit tests and we will review it. Unit tests are always needed.
There was a ZF1 ticket http://framework.zend.com/issues/browse/ZF-7570 that was a request to implement USE INDEX/FORCE INDEX in the Zend_Db_Select class.
It seems that this user implemented it directly within the main Zend_Db_Select class without any abstraction to the Adapters, would this have been incorrect?
If it was re-factored into such and CLA provided could it be implemented?
The text was updated successfully, but these errors were encountered: