[#3218] CS fixes

- whitespace after operators - use identity operator when testing against null - array/argument indentation
zendframework · Dec 19, 2012 · 0d697de · 0d697de
1 parent 063ebe9
commit 0d697de
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/library/Zend/Code/Generator/DocBlock/Tag/LicenseTag.php b/library/Zend/Code/Generator/DocBlock/Tag/LicenseTag.php
@@ -19,7 +19,6 @@
  */
 class LicenseTag extends Tag
 {
-
     /**
      * @var string
      */
@@ -36,7 +35,7 @@ public function __construct(array $options = array())
             $this->setUrl($options['url']);
         }
 
-        if(empty($this->name)) {
+        if (empty($this->name)) {
             $this->setName('license');
         }
     }
@@ -88,9 +87,8 @@ public function getUrl()
     public function generate()
     {
         $output = '@' . $this->name
-                . (($this->url != null) ? ' ' . $this->url : '')
-                . (($this->description != null) ? ' ' . $this->description : '');
+                . (($this->url !== null) ? ' ' . $this->url : '')
+                . (($this->description !== null) ? ' ' . $this->description : '');
         return $output;
     }
-
 }
diff --git a/tests/ZendTest/Code/Generator/DocBlockTagGeneratorTest.php b/tests/ZendTest/Code/Generator/DocBlockTagGeneratorTest.php
@@ -50,10 +50,14 @@ public function testCanPassDescriptionToConstructor()
 
     public function testCanGenerateLicenseTag()
     {
-        $tag = new LicenseTag(array('url' => 'http://test.license.com',
-                                    'description' => 'Test License'));
-        $this->assertEquals('@license http://test.license.com Test License',
-                $tag->generate());
+        $tag = new LicenseTag(array(
+            'url'         => 'http://test.license.com',
+            'description' => 'Test License',
+        ));
+        $this->assertEquals(
+            '@license http://test.license.com Test License',
+            $tag->generate()
+        );
     }
 
     public function testNameGetterAndSetterPersistValue()