Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Update library/Zend/Db/Adapter/Platform/Mysql.php #2392

Closed
wants to merge 1 commit into from
Closed

Update library/Zend/Db/Adapter/Platform/Mysql.php #2392

wants to merge 1 commit into from

Conversation

albulescu
Copy link
Contributor

For future versions of mysql you dont need to quote numbers.

The issue was when i use db->limit(10), in Select::processOffset
the limit and offset is quoted with quoteValue.

For future versions of mysql you dont need to quote numbers.

The issue was when i use db->limit(10), in Select::processOffset 
the limit and offset is quoted with quoteValue.
@ghost ghost assigned ralphschindler Sep 20, 2012
@ralphschindler
Copy link
Member

I don't think this is the right approach to the limit/offset problem MySQL has with unquoted values. By doing this, it will not quote values in other places like if someone were to produce, for example, an INSERT with values.

@albulescu
Copy link
Contributor Author

Yes you are right, maybe the correct aproach is in the processOffset and processLimit...

@ghost
Copy link

ghost commented Oct 7, 2012

I just came accross with this issue. Can this be just pass an optional second argument within quoteValue to represent where the value will be going.

$platform->quoteValue($this->limit, 'limit');

then we can know if the value we are quoting is a column value or a part of limit in a platform specific way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants