This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Db\Sql\Select: Fixed issue with join expression named parameters overlapping. #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed issue where multiple join's with expressions would overlap named parameters
ghost
assigned 
| @@ -620,7 +620,7 @@ protected function processJoins(PlatformInterface $platform, Adapter $adapter = | |||
| : $platform->quoteIdentifier($join['name']); | |||
| // on expression | |||
| $joinSpecArgArray[$j][] = ($join['on'] instanceof ExpressionInterface) | |||
| ? $this->processExpression($join['on'], $platform, $adapter, $this->processInfo['paramPrefix'] . 'join') | |||
| ? $this->processExpression($join['on'], $platform, $adapter, $this->processInfo['paramPrefix'] . 'join' . ($j+1) . 'part') | |||
There was a problem hiding this comment.
Need a comment in the code explaining what is happening with that last argument -- what it's creating, and why -- so that others coming in later know why it's there.
* added commentary on the processExpression() call within processJoins()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported in #2416