This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update library/Zend/Http/Header/SetCookie.php #2421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookies were not handled correctly. If you had a cookie for .sub.domain.de from the last response and then fired a new request to www.sub.domain.de, the old cookie was not added to the request (because .sub.domain.de is a substring of www.sub.domain.de, it should be added, the method should return true which was not the case).
ghost
assigned 
|
@PHPGangsta Can you add a test for this please? I'm worried that, due to the small change, the condition could be toggled again in the future, and without a test, go unnoticed. |
|
@weierophinney Added a test and some assertions. Can you please check it? I don't have phpunit running here (crappy windows with old phpunit 3.5.14). Travis says it's fine, and I hope the assertions are correct. Without the bugfix, the first and second assertion should fail I think. |
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookies were not handled correctly. If you had a cookie for .sub.domain.de from the last response and then fired a new request to www.sub.domain.de, the old cookie was not added to the request (because .sub.domain.de is a substring of www.sub.domain.de, it should be added, the method should return true which was not the case).