This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix for setJsonpCallback not called when recieved JsonModel + test #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@basz The branch appears to be missing, and as such, I cannot pull. :-( |
|
@weierophinney excuse me, git wars... please see this identical new PR : #2643 |
|
Close in favor of #2643 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resubmitted cleanly without all the git cruft woot!
When JsonStrategy::selectRenderer is called with an instanceof JsonModel in the event, the renderer would not be configured.
This is only an issue with accept header 'application/javascript' AND $request->getQuery()->get('callback') is available.
Reason is that it would return a renderer early based on the instance type at https://github.com/zendframework/zf2/blob/master/library/Zend/View/Strategy/JsonStrategy.php#L87