fix redundance errors "The input does not appear to be a valid date" show twice #2633
fix redundance errors "The input does not appear to be a valid date" show twice #2633
Conversation
Please add a unit test for this; it's hard to tell what exactly this fix accomplishes currently. |
@weierophinney : I added a unit test, and the result of markup of element rendered is success. not twice. but if : if (false === $date || $errors['warning_count'] > 0) { http://samsonasik.files.wordpress.com/2012/10/screen-shot-2012-10-03-at-12-16-13-pm.png and if i remove |
…nasik/zf2 into hotfix/zend-validator-date
- Fix in #2633, while mostly correct, let $date with bool false value continue as valid, which it should not. Added another conditional, which ensures reported issue still is fixed, while keeping original behavior.
@weierophinney : how about :
OR, what about :
The && operator fix this problem. |
- Fix in zendframework/zendframework#2633, while mostly correct, let $date with bool false value continue as valid, which it should not. Added another conditional, which ensures reported issue still is fixed, while keeping original behavior.
Fix The input does not appear to be a valid date that show twice.