This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed Zend\Math\Rand::getString() to pass the parameter $strong to ::getBytes() #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to test this? If so, could you please do so, @bschussek ? |
ghost
assigned 
|
@weierophinney I tried to figure one out. The problem is that the existing tests are very scarce, $strong in general isn't even tested. Maybe the original authors of Rand can help here? |
|
@bschussek Yeah, on reflection, I'm not sure there is a way to test this. I'll merge. |
weierophinney
added a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parameter $strong wasn't passed from getString() to getBytes() in the default chase that $charlist was empty. This PR fixes that.