This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[2.1][File Upload] Change file upload filtering to preserve the $_FILES array #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
kbabioch
pushed a commit
to kbabioch/zf2
that referenced
this pull request
Dec 19, 2012
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes, the
\Zend\InputFilter\FileInputwould pull out the$file['tmp_name']and pass that value along through the$filterChain->filter($tmp_name). This had the unfortunate affect of losing the$_FILESdata when doing a$form->getData()- only the'tmp_name'value would be returned for file inputs.The PR changes
\Zend\InputFilter\FileInputso that the$_FILESarray data is sent through the filter chain, and the\Zend\Filter\Filefilters now accept an array of$_FILESdata or a file path string (without any BC).$form->getData()will also return the expected$_FILESarray for any file inputs.Also patched the
FilePostRedirectGetcontroller plugin, which was affected by these changes.