This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Navigation] Allow non-string permissions #4564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you attach some unit tests for this change, or direct me to the unit tests that might already cover this use case? |
|
@ralphschindler There's none in there for string only either at present. I will try and get some in when I have a minute.. |
|
@ralphschindler tests added, ready for merge. |
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2013
[Navigation] Allow non-string permissions
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2013
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
…/patch-10 [Navigation] Allow non-string permissions
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-navigation
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows, for example, an array of permissions or permission objects to be attached to a page.