Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Added optional charset to pdo dsn #5064

Closed

Conversation

stefankleff
Copy link
Contributor

It was not possible to set the charset of the connection, now it can be passed as configuration parameter.

If somebody could give me a hint how - I'll also write a test :)

@EvanDotPro
Copy link
Member

The correct place to add a test for this would be ./tests/ZendTest/Db/Adapter/Driver/Pdo/ConnectionTest.php.

Unfortunately, it looks like there's not really any existing tests for this class for you to reference. Also, the way the connect() method is written doesn't allow for testing the DSN string building without actually invoking a real database connection, so writing a clean test for this without some refactoring would be pretty tough.

@stefankleff
Copy link
Contributor Author

That's why I've asked :) Unfortunately I don't have the time to refactor the class (and add test for that too).

@ralphschindler
Copy link
Member

I believe this was addressed with #4973

@ralphschindler ralphschindler self-assigned this Mar 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants