[Console] ViewManager hides exceptions in console

[Thinkscape]

This is what bugs me very often:

Because in production we'll usually see:

    'view_manager' => [
        'display_not_found_reason' => false,
        'display_exceptions'       => false,
    ],

... it will also affect console rendering of exceptions. It's not easily solvable when using config caching, because tricks like conditionals in config files are uncacheable.

I see couple of solutions:

1. Ignore this setting when running in console (under the assumption that we always want to see exceptions in console as it's a protected environment)
2. Separate the setting, i.e. add display_exceptions_console.

[Thinkscape]

I welcome your thoughts on that. Meanwhile, here's a dirty workaround:

    public function onBootstrap(MvcEvent $e)
    {
        $sm = $e->getApplication()->getServiceManager();

        // Fix exceptions not displaying in console
        if (Console::isConsole()) {
            /** @var ViewManager $vm */
            $vm = $sm->get('ViewManager');
            $vm->getExceptionStrategy()->setDisplayExceptions(true);
        }
    }

[veewee]

+1

[gianarb]

Separate the setting, i.e. add display_exceptions_console.

I'm for this solution

[texdc]

What about console-specific configs with console or console-view?

'console' => [
    'display_not_found_reason' => true,
    'display_exceptions'       => true,
],

[jeremiahsmall]

+1 for @texdc idea, except maybe should be all view_manager options in the same manner that we have router overrides for console.

'console' => [
    'router' => [
        // …stuff
    ],
    'view_manager' => [
        'display_not_found_reason' => true,
        'display_exceptions'       => true,
    ]
]

[Thinkscape]

@texdc The actual implementation sits in a console-specific ViewManager, which is very similar to standard http ViewManager so I want to keep it consistent.

That means, that @jeremiahsmall is on the money with how we should probably nest it (which is in-line with how we nest console router config)

@weierophinney as you're the original ViewManager author, do you have anything against me separating those ViewManager configs?

[texdc]

@Thinkscape @jeremiahsmall 👍 nested is fine with me.

[macnibblet]

👍 I have found this issue to be a pain in the ******

[weierophinney]

@Thinkscape separating configs based on context makes a ton of sense to me.

[Ocramius]

Handled in #6951

[macnibblet]

Le awesome!