This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
#ZF2-319 Fix multi search and access document #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update unit tests for access document on mutlisearch
multiindex have problems with access document. Id (which is the document id) has change, so access document is broken.
|
I get 25 new test failures in the Zend\Search\Lucene suite when applying this: http://pastebin.com/EY1YK6iT Please correct and update the PR when ready. Thanks! |
|
Oh strange, i was runned Zend\Search\Lucene suite. I will correct & update, sorry. |
|
It's ok now. |
discard change and commit good version - discard id increment value and keep orginal instructions incrementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit id must be changed because it's the document id.
To fix that, i add a "document_id" and the id will be the uniq id.