This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[WIP] loadModule event and ServiceListener support for Modules #1949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for modules to listen to the
loadModule(ModuleEvent)
and to add an own Service Manager to theServiceListener
.While this is nice to have, it adds some overhead which might not be necessary considering the rare use case. The overhead is mainly caused by the Event Manager/Listeners, and not by the Module Manager.
Benchmark (best of 10 requests):
Imho, this should only be merged, if we can squeeze some performance out of ZF2.