This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added test for ZF2-569 string with trailing 0's i.e. '10.0' #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed based on fix in #2388 |
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet a hotfix, because I have no idea what would be the best way to approach this. Problem is described in http://framework.zend.com/issues/browse/ZF2-569
When submitting a string like '10.50' to the float validator it fails because the parsing gets rid of the trailing zeros and the string comparision at the end fails.
Maybe someone has an easy idea how to handle this? run the valueFiltered through the numberformatter gives errors, converting a string to float fails as well.