This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[BUG] Service Manager Not Shared Duplicate new Instance with multiple Abstract Factories #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2012 13:26
…teNewInstanceMultipleAbstractFactories 1 error
| if ($abstractFactory->canCreateServiceWithName($this, $canonicalName, $requestedName)) { | ||
| $this->pendingAbstractFactoryRequests[get_class($abstractFactory)] = $requestedName; |
| @@ -654,4 +654,17 @@ public function testCanGetAliasedServicesFromPeeringServiceManagers() | |||
|
|
|||
| $this->assertSame($service, $this->serviceManager->get('alias-name')); | |||
| } | |||
|
|
|||
| /** | |||
added 4 commits
December 17, 2012 14:10
ghost
assigned
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test: ZendTest\ServiceManager\ServiceManagerTest::testDuplicateNewInstanceMultipleAbstractFactories
Test fails with 1 error.
If an Abstract Factory cannot create an instance, a pendingAbstractFactoryRequests key is left set.
This pendingAbstractFactoryRequests key forces canCreateFromAbstractFactory to return false.
Fix suggestion supplied:
set $this->pendingAbstractFactoryRequests[get_class($abstractFactory)] = $requestedName;
only when $abstractFactory->canCreateServiceWithName($this, $canonicalName, $requestedName) returns true.
All Service Manager Tests pass with supplied fix.