remove '\' character from Traversable #3679
Conversation
| @@ -16,7 +16,7 @@ | |||
| /** | |||
| * Create and return a Feed based on data provided. | |||
| * | |||
| * @param array|\Traversable $data | |||
There was a problem hiding this comment.
there is "use Traversable" at the top of the file, so it's correct ?
There was a problem hiding this comment.
'use' statement can make docblock simpler. it can reduce deep namespace calling.
There was a problem hiding this comment.
Calling for who. Remember that this is a comment and should not have runtime effects unless you use Reflection|Zend\Code
There was a problem hiding this comment.
I see a ton of simplify-ing docblock in zf2 source files because of already in use statement. /cc @weierophinney
There was a problem hiding this comment.
@Maks3w declaring an import is a no-op if the code never hits it; as such,
declaring imports for classes only referenced in docblocks provides no
runtime hit, but does allow for better readability. This change is fine.
On Wednesday, February 6, 2013, Maks wrote:
In library/Zend/Feed/Writer/FeedFactory.php:
@@ -16,7 +16,7 @@
/**
* Create and return a Feed based on data provided.
*
\* @param array|\Traversable $dataCalling for who. Remember that this is a comment and should not have
runtime effects unless you use Reflection|Zend\Code—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3679/files#r2906160.
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
ghost
assigned 
because already defined in 'use' statement