This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Form] [Hotfix] Get Elements for Collection #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,6 +330,19 @@ public function getTargetElement() | |||
| } | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
| * | |||
| * If the target element is a FieldsetInterface, return it's attached elements | |||
There was a problem hiding this comment.
s/it's/its/ (possessive, not contraction) (I will do this on merge, most likely)
|
@davidwindell Ping me when you've made the changes you and @bakura10 have discussed. |
|
Ping @weierophinney OK, i've refactored that now. The only thing I can see missing for future consideration is that we don't have handling for any fieldsets within the target element (fieldset) of a Collection. |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2013
…ments [Form] [Hotfix] Get Elements for Collection
weierophinney
added a commit
that referenced
this pull request
Apr 17, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the
useInputFilterDefaultsflag on Forms doesn't work correctly with Collections that have a Fieldset attached as their target elements. This means that data may go unfiltered when it is expected to be using the filters/validators available on Form Elements.This PR allows retrieval of the elements of the target element via the collection so that the correct defaults can be applied.