This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix to enforce $length data type to be int in getBytes.
If the data type of $length is float (even if the float is an integer value) the this
if
fails: https://github.com/zendframework/zf2/blob/master/library/Zend/Math/Rand.php#L55 and can, in some php environments, result in this error being falsely thrown:https://github.com/zendframework/zf2/blob/master/library/Zend/Math/Rand.php#L62
Just to add the quirk, the
ciel
function always returns a float, so this line https://github.com/zendframework/zf2/blob/master/library/Zend/Math/Rand.php#L187 can cause the faulty behavior (which is how I found the problem).There is no test attached, because I don't know how to test for this properly due to it's environment specific nature. It will only show if ssl is not installed, and these alternatives are also not available: https://github.com/zendframework/zf2/blob/master/library/Zend/Math/Rand.php#L59