This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow iterator as parameter for Zend\Mail\Transport\Smtp constructor #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,7 @@ class Smtp implements TransportInterface | |||
| public function __construct(SmtpOptions $options = null) | |||
| { | |||
| if (!$options instanceof SmtpOptions) { | |||
| $options = new SmtpOptions(); | |||
| $options = new SmtpOptions($options); | |||
There was a problem hiding this comment.
This doesn't make any sense. According the the strict-type in line 50, $options must be either of type SmtpOptions or null. If $options is not an instance of SmtpOptions, then it must be null. Therefore, why would you pass it into new SmtpOptions?
There was a problem hiding this comment.
Oh right, I didn't see the strict parameter in line 50.
I am accustomed to use array instead of WhateverOptions.
It use "instanceof" checking instead of "null === $var".
So I thought the author wanted to allow either array, or instanceof SmtpOptions as parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess it is a simple oversight.