Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Implementation of inTransaction() in all Zend\Db\Adapter\Drivers #5747

Closed
wants to merge 1 commit into from
Closed

Implementation of inTransaction() in all Zend\Db\Adapter\Drivers #5747

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2014

I wanted to add this pull request to Issue #5744

@Maks3w
Copy link
Member

Maks3w commented Feb 22, 2014

@ralphschindler Should this method be added to ConnectionInterface?

@Maks3w Maks3w added the Db label Feb 22, 2014
@Maks3w Maks3w added this to the 2.2.6 milestone Feb 22, 2014
@ralphschindler
Copy link
Member

That would be a backwards incompatible change I think (to add it to the interface).

@Maks3w Maks3w modified the milestone: 2.2.6 Feb 28, 2014
@Maks3w
Copy link
Member

Maks3w commented Feb 28, 2014

Yes, It is.For 2.3 then?

@ralphschindler
Copy link
Member

I think adding methods to interfaces would need to wait till 3.0. Anyone that has written their own driver at this point should have the expectation that it will work throughout the 2.x series.

This PR, on the other hand, is perfectly fine to include in 2.3

@weierophinney
Copy link
Member

@ralphschindler Another possibility for adding methods is to add new interfaces, and make the default implementations implement those. Prior to calling any of the new methods, you check if the object implements the given interface. (We've done this many times now in the ZF2 lifecycle).

Based on your advice, marking for 2.3.0 and assigning to you, @ralphschindler .

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014
ralphschindler pushed a commit that referenced this pull request Mar 7, 2014
Merge branch 'master' of git://github.com/jonasdrieghe/zf2 into feature/5747

* 'master' of git://github.com/jonasdrieghe/zf2:
  Implementation of inTransaction() in all Zend\Db\Adapter\Drivers
ralphschindler pushed a commit that referenced this pull request Mar 7, 2014
Merge branch 'feature/5747' into develop

* feature/5747:
  Implementation of inTransaction() in all Zend\Db\Adapter\Drivers
@ralphschindler
Copy link
Member

Merged to develop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants