This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add a missing way to set the HTML attributes of the fieldset tag #5952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +172,8 @@ public function render(ElementInterface $element) | |||
| $type = $element->getAttribute('type'); | |||
| if ($type === 'multi_checkbox' || $type === 'radio') { | |||
| $markup = sprintf( | |||
| '<fieldset><legend>%s</legend>%s</fieldset>', | |||
| '<fieldset %s><legend>%s</legend>%s</fieldset>', | |||
There was a problem hiding this comment.
Replace "<fieldset %s" with "<fieldset%s" and add the space if $attributes isn't empty.
|
The attributes are also passed to multi_checkbox and used for the child elements. Any attributes used here will be used twice. Even ID will be rendered twice which will result in invalid HTML. While #5623 makes sense. This does not. FormRow adds the extra fieldset/legend to be able to render the group of elements correctly. It's not an ACTUAL fieldset you're rendering as in the case of FormCollection. |
|
@ZeinEddin we need a test for this. |
|
Closing due to lack of feedback from original author; feel free to re-open if/when you can add unit tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing way to set the HTML attributes of the fieldset tag as reported in #5553