This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Enhancement: Do not overwrite requestId if extra already has one #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative to this PR could be the introduction of a
Thoughts, anyone? |
|
Sorry, seems like I referenced the wrong PR from my branches... Re-opening |
|
Couldn't find a way to restart the build other than: |
|
Since behavior is being changed quite a bit here, I'm merging this one into develop only |
Ocramius
added a commit
that referenced
this pull request
Jul 27, 2014
|
Manually merged at @5869e9b9e90cf295fbe2bd1fc71d70e103d65d4f. Thanks @localheinz! |
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…ocessorpluginmanager' Close zendframework/zendframework#6178
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…ocessorpluginmanager' into develop Close zendframework/zendframework#6178 Forward Port zendframework/zendframework#6178
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…te-request-id' into develop Close zendframework/zendframework#6178
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
Processor\RequestIdso it does not overwrite a value forrequestIdin theextraarray.The reason I'm proposing this change is because I want to be able to pass on the
requestIdidentifier, for example, to aGearmanworker, so I can identify log entries related to the request that started a background job.