This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix / tests for #6363 #6400
Merged
Fix / tests for #6363 #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,78 @@ | |||
| <?php | |||
There was a problem hiding this comment.
@samsonasik I've just updated the file. Thank you
| @@ -638,6 +638,9 @@ protected function prepareValidationGroup(FieldsetInterface $formOrFieldset, arr | |||
| if (!isset($data[$key])) { | |||
| $data[$key] = array(); | |||
| } | |||
| } | |||
|
|
|||
| if(is_array($data[$key])) { | |||
There was a problem hiding this comment.
I came across this issue myself today and just moving everything inside the else block to outside fixed the issue for me...if you do that the is_array check won't be necessary.
Small code change accoording to @adamlundrigan suggestion. It make the code smaller and more logical, and the result is the same.
Jhiino
added a commit
to Jhiino/zf2
that referenced
this pull request
Oct 8, 2014
CaporalDead
added a commit
to Astek-GO/zf2
that referenced
this pull request
Oct 8, 2014
CF zendframework#6363 zendframework#6400 - Problème d'hydratation des nested collection sur les form, import d'une correction de Zf 2.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6363