Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Added some tests for #6499 #6503

Closed
wants to merge 3 commits into from
Closed

Added some tests for #6499 #6503

wants to merge 3 commits into from

Conversation

rahuldroy
Copy link
Contributor

No description provided.

*/
class EntityWithSpaceAnnotations
{
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that CS tests fail because of this intentional trailing space. Not sure yet about how to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius it seems we can set exclude for this file at .php_cs file ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsonasik that's some real good news, thanks! :-)

@Ocramius
Copy link
Member

Linking #6499

@ezimuel ezimuel added this to the 2.3.2 milestone Aug 6, 2014
@weierophinney
Copy link
Member

@Ocramius is this an issue specific to our annotation support, or is it an issue in the Doctrine annotation library?

@Ocramius
Copy link
Member

Ocramius commented Aug 7, 2014

Still not clear. I personally think Zend\Code may be passing a different string to the annotation parser.

@weierophinney weierophinney removed this from the 2.3.2 milestone Aug 7, 2014
@weierophinney
Copy link
Member

Removed milestone, as we cannot reliably reproduce.

In discussion with @Ocramius, it's possible that Zend\Code is passing an invalid string to the annotation parser. In looking at Zend\Code\Reflection\ClassReflection, however, the method we call is getAnnotations(), which passes the results of getDocComment() -- which is inherited directly from ReflectionClass. As such... this is very difficult to track.

@nickurt
Copy link

nickurt commented Aug 8, 2014

@weierophinney @Ocramius Thanks for the reply's, I debugged some things.

The file Zend\Code\Scanner\AnnotationScanner -> __construct returns the correct docComment, but it fails in the tokenize function (#ref).

The currentChar (#ref) is here ...

string(1) "/"
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "

@Ocramius
Copy link
Member

I see that this has indeed nothing to do with doctrine/annotations. Removing myself from the assignees as I cannot help with this issue right now.

@Ocramius Ocramius removed their assignment Nov 19, 2014
@Maks3w
Copy link
Member

Maks3w commented May 7, 2015

Do #7113 fix this?

@GeeH
Copy link

GeeH commented Jun 28, 2016

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html
New issue can be found at: zendframework/zend-code#79

@GeeH GeeH closed this Jun 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants