Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

added zendframework/zendxml into suggest at Zend\Json's composer.json #6778

Merged
merged 5 commits into from Nov 14, 2014
Merged

added zendframework/zendxml into suggest at Zend\Json's composer.json #6778

merged 5 commits into from Nov 14, 2014

Conversation

samsonasik
Copy link
Contributor

used by Zend\Json\Json::fromXml()

@Ocramius
Copy link
Member

Should probably be optional. Additionally, I'd suggest just deprecating this API, as it's just a problem to couple the Json component to zendframework/zendxml

@Ocramius Ocramius self-assigned this Oct 19, 2014
@samsonasik samsonasik changed the title added zendframework/zendxml into require at Zend\Json's composer.json added zendframework/zendxml into suggest at Zend\Json's composer.json Oct 19, 2014
@samsonasik
Copy link
Contributor Author

@Ocramius done ;). I've moved the zendxml to suggest and mark Json::fromXml() as @deprecated .

@adamlundrigan
Copy link
Contributor

👍. I would prefer to see a separate "XmlToJson" component that composes both Zend\Json and Zend\Xml to perform the conversion, rather than direct dependency between the two components.

My only suggestion here is to note why the method is deprecated - either a short blurb or a link to this ticket - so that when it comes time to update this component for ZF3 we'll know why it was done.

@samsonasik
Copy link
Contributor Author

@adamlundrigan I have added this PR id after @deprecated docblock

@gianarb
Copy link
Contributor

gianarb commented Nov 14, 2014

@samsonasik 👍

@Ocramius Ocramius added this to the 2.3.4 milestone Nov 14, 2014
@Ocramius Ocramius merged commit a08972e into zendframework:master Nov 14, 2014
Ocramius added a commit that referenced this pull request Nov 14, 2014
@Ocramius
Merge branch 'hotfix/#6778-zendxml-suggestion-in-zend-json'
eaf9dd3 
Close #6778
Ocramius added a commit that referenced this pull request Nov 14, 2014
@Ocramius
Merge branch 'hotfix/#6778-zendxml-suggestion-in-zend-json' into develop
d06f74e 
Close #6778
Forward port #6778
@Ocramius
Copy link
Member

@samsonasik merged, thx!

master: eaf9dd3
develop: d06f74e

@samsonasik samsonasik deleted the zendxml-composer-json branch November 14, 2014 23:53
@samsonasik samsonasik mentioned this pull request Nov 18, 2014
Closed
Ocramius added a commit that referenced this pull request Nov 18, 2014
@Ocramius
Merge branch 'hotfix/#6891-#6778-composer-json-string-escaping'
88c124c 
Close #6891
Ocramius added a commit that referenced this pull request Nov 18, 2014
@Ocramius
Merge branch 'hotfix/#6891-#6778-composer-json-string-escaping' into …
2851a22 
…develop

Close #6891
Forward port #6891
gianarb pushed a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6778-zendxml-suggest…
cb7491a 
…ion-in-zend-json'

Close zendframework/zendframework#6778
gianarb pushed a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6778-zendxml-suggest…
3cbb921 
…ion-in-zend-json' into develop

Close zendframework/zendframework#6778
Forward port zendframework/zendframework#6778
@rakesh-beedasy
Copy link

Why is Zend\Xml2Json\Xml2Json::fromXml marked as deprecated in zf3 ?

@weierophinney
Copy link
Member

Why is Zend\Xml2Json\Xml2Json::fromXml marked as deprecated in zf3 ?

It's not; the method for doing so in Zend\Json\Json has been extracted into its own package, zendframework/zend-xml2json.

@rakesh-beedasy
Copy link

https://github.com/zendframework/zend-xml2json/blob/master/src/Xml2Json.php#L45

samsonasik added a commit to samsonasik/zend-xml2json that referenced this pull request May 4, 2016
@samsonasik
remove @deprecated note comes from zendframework/zendframework/pull/6778
005c02e 


in favor of zendframework/zendframework#6778 (comment)
@samsonasik samsonasik mentioned this pull request May 4, 2016
Merged
@samsonasik
Copy link
Contributor Author

@rakesh-beedasy I've created PR for @deprecated doc removal for that: zendframework/zend-xml2json#1

@rakesh-beedasy
Copy link

Thanks 👍

weierophinney added a commit to zendframework/zend-xml2json that referenced this pull request Oct 16, 2017
@weierophinney
Merge pull request #1 from samsonasik/patch-1
100f6e4 
remove @deprecated doc came from zendframework/zendframework/pull/6778
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
bug Json
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samsonasik @Ocramius @adamlundrigan @gianarb @rakesh-beedasy @weierophinney