This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed: Form/Element/Collection can't remove all elements #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was checking empty collection that's why it had 0 after `$collection->populateValues(array());`
|
just fixed test because it was checking for empty collection to be empty.. maybe someone can help with fix? |
not sure I am allowed to do this
|
tests failing because of another bug fixed in #7446 when merged should be ok |
|
@weierophinney is it possible to merge this in 2.4.1? It is impossible to use Form/Element/Collection without workarounds. |
svycka
changed the title
|
fixed with zendframework/zend-form#14 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues: #7446 #4492