Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated docker builds seem to be broken #135

Open
cornim opened this issue Jan 24, 2020 · 8 comments
Open

Automated docker builds seem to be broken #135

cornim opened this issue Jan 24, 2020 · 8 comments

Comments

@cornim
Copy link

cornim commented Jan 24, 2020

Last build on Docker Hub is over 1 year old and on version 0.1dev

@zenhack
Copy link
Owner

zenhack commented Jan 25, 2020

Thanks for the report.

I'm not 100% sure we ever had automated builds working. @buchdag, do you recall? I remember we had a lot of trouble with it, and I don't have a memory of having actually solved the issue.

I triggered the build manually, so we should have a new one soon.

@rejinka
Copy link

rejinka commented Mar 11, 2020

I got an email, which notified me, that 0.7 isn't going to be supported anymore, as it uses the v1 endpoint. So i tried to update, but there aren't any stable tags, only "latest" (i used zenhack/simp_le@sha256:9cfaf23695a794c4df2ffcd5c5185c79720fe912f63087912e5d9b81017d8f84), which seems to be a develop-build. But i cannot verify that.

If i can provide any help on the automated builds, let me know.

@zenhack
Copy link
Owner

zenhack commented Mar 11, 2020

Right now latest should be the same as the 0.17 release. It's built from master, but there weren't actually any changes between the release and then.

It does look like at some point we consistently had new images for each tag. I'll see if I can dig into why they aren't building anymore.

@buchdag
Copy link
Contributor

buchdag commented Mar 12, 2020

@zenhack I confirm that Docker automated build never worked, as far as I remember you did not manage to sync your Dockerhub and GitHub accounts to trigger the build on new pushes / tags, and we never were able to understand why.

We had new images for tagged release because I was manually triggering them with a Build Trigger URL (a POST request against DockerHub API) you provided me. I was under the impression that no one really used the Docker version anyway so I stopped doing that a while ago.

@buchdag
Copy link
Contributor

buchdag commented Mar 12, 2020

If the Docker version is actually used maybe I should resume work on it.

@zenhack
Copy link
Owner

zenhack commented Mar 12, 2020

If you want to do that it would be appreciated. I spent a bit of time futzing with trying to get it to connect the account, pushed a commit to test, but no luck.

@rejinka
Copy link

rejinka commented May 13, 2020

@buchdag do you manage @zenhack's dockerhub account? I'm a bit confused here. For a test, i set up https://hub.docker.com/repository/docker/naji/simp_le, which is connected to https://github.com/rejinka/simp_le. I managed to get autobuilding:

  • new docker-tag "latest", if master is pushed
    • Source-Type: Branch
    • Source: master
    • Docker Tag: latest
    • Dockerfile location: docker/Dockerfile
    • Build Context: /
  • new docker-tag based on a git-tag, if git-tag is pushed.
    • Source-Type: Tag
    • Source: /^[0-9.]+$/
    • Docker Tag: {sourceref}
    • Dockerfile location: docker/Dockerfile
    • Build Context: /

Also i found a way, to force the build of old tags. Assuming, you've configured a "Build trigger" with url http://example.com/trigger and a tag 0.18.0, you can call
curl -H "Content-Type: application/json" -X POST --data '{"source_type": "Tag", "source_name": "0.18.0"}' http://example.com/trigger to force the build a docker image with corresponding tag.

If you've got any trouble, setting this up, we can try to solve those, having a call or something.

@rejinka
Copy link

rejinka commented Sep 2, 2020

Is there any interest to get this fixed? If not, please close the issue and i'll figure out what i can do myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants