🚧 Remove lodash from immutadot package #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frinyvonnick
changed the title
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 76 77 +1
Lines 252 280 +28
=====================================
+ Hits 252 280 +28
Continue to review full report at Codecov.
|
nlepage
changed the title
frinyvonnick
force-pushed
the
refactore/remove-lodash
branch
2 times, most recently
from
937021f
to
c3a0d6a
Compare
nlepage
force-pushed
the
refactore/remove-lodash
branch
from
8e0541a
to
e0fa69b
Compare
nlepage
force-pushed
the
refactore/remove-lodash
branch
from
e0fa69b
to
b9ea095
Compare
nlepage
requested changes
Dec 7, 2017
| @@ -0,0 +1,10 @@ | |||
| import { convert } from './convert' | |||
There was a problem hiding this comment.
This import is undefined, only convertLodashFp is exported.
I think no index is necessary for util namespace in immutadot-lodash...
| @@ -2,3 +2,4 @@ export * from './array' | |||
| export * from './collection' | |||
| export * from './object' | |||
| export * from './string' | |||
| export * from './util' | |||
There was a problem hiding this comment.
Not sure this should be exported
| import map from 'lodash/map' | ||
| import mapValues from 'lodash/mapValues' | ||
| import omit from 'lodash/omit' | ||
| const isSymbol = sym => typeof sym === 'symbol' |
| @@ -45,7 +53,7 @@ class ChainWrapper { | |||
| * @since 0.1.11 | |||
| */ | |||
| _absolutePath(path) { | |||
| return concat(toPath(this._path), toPath(path)) | |||
| return [].concat(unsafeToPath(this._path), unsafeToPath(path)) | |||
There was a problem hiding this comment.
unsafeToPath is guaranted to return an array, and concat doesn't mutate the array, so you can do unsafeToPath(this._path).concat(unsafeToPath(path))
|
|
||
| const head = arr => arr[0] | ||
|
|
||
| const drop = (arr, n = 1) => arr.slice(n) |
| const args = concat( | ||
| map(this._paths, usingPath => { | ||
| const args = [].concat( | ||
| this._paths.map(usingPath => { |
There was a problem hiding this comment.
this._paths is guaranted to be an array, and concat doesn't mutate, call this._paths.concat
| @@ -34,7 +36,7 @@ class ProtectHandler { | |||
| get(target, property) { | |||
| const reference = this._peek()[property] | |||
| if (!isObject(reference)) return reference | |||
| return new Proxy(reference, new ProtectHandler(this.chainWrapperRef, concat(this.path, property))) | |||
| return new Proxy(reference, new ProtectHandler(this.chainWrapperRef, [].concat(this.path, property))) | |||
| @@ -46,7 +48,7 @@ class ProtectHandler { | |||
| * @since 0.3.0 | |||
| */ | |||
| set(target, property, value) { | |||
| this.chainWrapperRef.chainWrapper = this.chainWrapperRef.chainWrapper.set(concat(this.path, property), value) | |||
| this.chainWrapperRef.chainWrapper = this.chainWrapperRef.chainWrapper.set([].concat(this.path, property), value) | |||
| @@ -58,7 +60,7 @@ class ProtectHandler { | |||
| * @since 0.3.0 | |||
| */ | |||
| deleteProperty(target, property) { | |||
| this.chainWrapperRef.chainWrapper = this.chainWrapperRef.chainWrapper.unset(concat(this.path, property)) | |||
| this.chainWrapperRef.chainWrapper = this.chainWrapperRef.chainWrapper.unset([].concat(this.path, property)) | |||
nlepage
reviewed
Dec 7, 2017
| @@ -60,7 +68,7 @@ class ChainWrapper { | |||
| return new ChainWrapper( | |||
| this._wrapped, | |||
| this._path, | |||
| concat(this._flow, object => fn(object, this._absolutePath(path), ...args)), | |||
| [].concat(this._flow, object => fn(object, this._absolutePath(path), ...args)), | |||
There was a problem hiding this comment.
We only add one element, I think we can use this._flow.push
nlepage
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Remove lodash from immutadot package
Issue : #78