Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: Handle list notation #162

Merged
merged 2 commits into from
Dec 13, 2017
Merged

apply: Handle list notation #162

merged 2 commits into from
Dec 13, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 12, 2017

Issue : #139

@nlepage nlepage added this to the 1.0.0-RC1 milestone Dec 12, 2017
@nlepage nlepage self-assigned this Dec 12, 2017
@codecov-io
Copy link

codecov-io commented Dec 12, 2017 •
edited

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #162   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          79     79           
  Lines         306    315    +9     
=====================================
+ Hits          306    315    +9
Impacted Files Coverage Δ
packages/immutadot/src/path/apply.js 100% <100%> (ø) ⬆️
packages/immutadot/src/path/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08fde6...c3a6fee. Read the comment docs.

@nlepage nlepage requested a review from charlyx December 12, 2017 21:41
frinyvonnick
frinyvonnick approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, we should start thinking about a way to make apply more readable 👍

@nlepage nlepage merged commit 92f08e6 into master Dec 13, 2017
@nlepage nlepage deleted the feature/139 branch December 13, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

@charlyx charlyx Awaiting requested review from charlyx

Assignees

@nlepage nlepage

Labels
✨ feature
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlepage @codecov-io @frinyvonnick