Enhance the benchmark #209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 93 93
Lines 267 267
=====================================
Hits 267 267Continue to review full report at Codecov.
|
nlepage
force-pushed
the
benchmark/enhance
branch
2 times, most recently
from
0d928f6
to
455857a
Compare
nlepage
force-pushed
the
benchmark/enhance
branch
from
455857a
to
58f3fe5
Compare
nlepage
force-pushed
the
benchmark/enhance
branch
from
f592cd7
to
5ba342f
Compare
| export function createBenchmark(title, testResult, pMaxTime = 30, pMaxOperations = 1000) { | ||
|
|
||
| const fast = Boolean(process.env.FAST) | ||
| const maxTime = fast ? pMaxTime / 3 : pMaxTime, maxOperations = fast ? Math.round(pMaxOperations / 3) : pMaxOperations |
There was a problem hiding this comment.
Maybe on two lines so it would be clearer with the ternary operator ?
|
|
||
| it('ES2015', () => { | ||
| benchmark('es2015', 'ES2015 destructuring', () => { | ||
| const start = randomStart(), end = start + modifySize |
There was a problem hiding this comment.
It's more readable than the previous one with ternary operators but i found it hard to view each variables at one glance.
|
|
||
| it('ES2015', () => { | ||
| benchmark('es2015', 'ES2015 destructuring', () => { | ||
| const start = randomStart(), end = start + modifySize |
There was a problem hiding this comment.
Maybe we could create a function getTestBounds which return an array with start and end value ?
|
|
||
| const runs = [] | ||
|
|
||
| function run(key, opTitle, operation) { |
There was a problem hiding this comment.
Maybe you could add more comments to explain more your approach ? Or a pointer on the method you followed ?
There was a problem hiding this comment.
I'll document in a later PR, created an issue #223
No description provided.