Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/130 #259

Merged
merged 6 commits into from
May 3, 2018
Merged

Enhance/130 #259

merged 6 commits into from
May 3, 2018

Conversation

frinyvonnick
Copy link
Contributor

Prerequisites

Description

Reorder immutaTest args

Issue : #130

@codecov-io
Copy link

codecov-io commented Apr 30, 2018 •
edited

Codecov Report

Merging #259 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #259   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        96     96           
  Lines       279    279           
===================================
  Hits        279    279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c87810...ff3a65b. Read the comment docs.

@frinyvonnick
Copy link
Contributor Author

frinyvonnick commented Apr 30, 2018 •
edited

It's working but i'm not totally satisfied with code formatting. Do i look further to improve it @nlepage (example: no new lines at each array elements) ?

I used this code to achieve this refactoring.

@nlepage
Copy link
Member

nlepage commented May 2, 2018

LGTM despite the formatting.
What formatting would you like ? One line per argument of immutaTest ?

@frinyvonnick
Copy link
Contributor Author

It was more about arrays but if it's good for you 👌

nlepage
nlepage previously approved these changes May 2, 2018
View reviewed changes
@frinyvonnick frinyvonnick changed the base branch from master to dev May 3, 2018 08:10
@frinyvonnick frinyvonnick merged commit afdcc17 into dev May 3, 2018
@frinyvonnick frinyvonnick deleted the enhance/130 branch May 3, 2018 08:13
nlepage pushed a commit that referenced this pull request Jan 22, 2019
@frinyvonnick @nlepage
✅ Reorder immutaTest params (#259)
b3a27bd 
* 🚧 Start refactoring immutaTest

* 🐛 Add paths in callback call

* ✅ Reorder immutaTest params in core package

* ✅ Reorder immutaTest params in lodash package

* 🔀 Fix after rebase

* 🔀 Fix after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlepage nlepage nlepage left review comments

Assignees
No one assigned
Labels
❓ question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frinyvonnick @codecov-io @nlepage