Add init function #288
Merged
Add init function #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #288 +/- ##
===================================
Coverage 100% 100%
===================================
Files 96 97 +1
Lines 279 280 +1
===================================
+ Hits 279 280 +1
Continue to review full report at Codecov.
|
nlepage
reviewed
May 4, 2018
There was a problem hiding this comment.
LGTM, however I'm not quite sure of the name init, it is very vague.
I had thought of create, which is much more familiar, but since there is no prototype involved here it is a bit misleading.
@frinyvonnick What do you think ?
|
I guess, you are right. |
nlepage
previously approved these changes
May 14, 2018
| import { create } from 'object' | ||
| import { immutaTest } from 'test.utils' | ||
| describe('object.create', () => { | ||
| it('should createialize objects', () => { |
nlepage
approved these changes
May 14, 2018
nlepage
pushed a commit
that referenced
this pull request
Jan 22, 2019
* ✨ Add init function in object namespace * 🚚 Rename init into create * ✏️ Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Add init function
Issue : #234