Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix typo in the getting started doc #314

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

ClementVanPeuter
Copy link
Contributor

@ClementVanPeuter ClementVanPeuter commented Nov 29, 2018

Prerequisites

Description

Fixing a typo in the getting started doc.

Before

 const newAnimals = {
  ...animals,
  weasels: {
    ...animals.weasels,
    lutraLutra: {
      ...animals.weasels.otter,
      name: 'Lutra lutra',
    },
  },
}

After

const newAnimals = {
  ...animals,
  weasels: {
    ...animals.weasels,
    otter: {
      ...animals.weasels.lutraLutra,
      name: 'Lutra lutra',
    },
  },
}

@@ -52,8 +52,8 @@ const newAnimals = {
...animals,
weasels: {
...animals.weasels,
lutraLutra: {
...animals.weasels.otter,
otter: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be lutraLutra everywhere, we don't want to create an otter object, but rather set a name prop on the lutraLutra object.

Suggested change
otter: {
lutraLutra: {

@frinyvonnick
Copy link
Contributor

frinyvonnick commented Nov 29, 2018

This should be 😄

const newAnimals = {
  ...animals,
  weasels: {
    ...animals.weasels,
    lutraLutra: {
      ...animals.weasels.lutraLutra,
      name: 'Lutra lutra',
    },
  },
}

Edit:
@nlepage has been faster 👍

@nlepage nlepage merged commit 36e2876 into master Nov 30, 2018
@nlepage nlepage deleted the fix-getting-started-typo branch November 30, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants