Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace convert by new apply #319

Merged
merged 13 commits into from
Dec 10, 2018
Merged

Replace convert by new apply #319

merged 13 commits into from
Dec 10, 2018

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 3, 2018

Issue : fix #304

@nlepage nlepage added this to the 2.0 milestone Dec 3, 2018
@nlepage nlepage self-assigned this Dec 3, 2018
@codecov-io
Copy link

codecov-io commented Dec 3, 2018 •
edited

Codecov Report

Merging #319 into feature/305 will increase coverage by 0.37%.
The diff coverage is 98.38%.

Impacted file tree graph

@@               Coverage Diff               @@
##           feature/305     #319      +/-   ##
===============================================
+ Coverage        96.68%   97.05%   +0.37%     
===============================================
  Files              108      104       -4     
  Lines              452      374      -78     
===============================================
- Hits               437      363      -74     
+ Misses              15       11       -4
Impacted Files Coverage Δ
...kages/immutadot-lodash/src/util/lodashFpConvert.js 100% <ø> (ø) ⬆️
packages/immutadot/src/nav/nav.js 87.5% <ø> (ø) ⬆️
packages/immutadot-lodash/src/array/take.js 100% <100%> (ø) ⬆️
...ackages/immutadot-lodash/src/collection/orderBy.js 100% <100%> (ø) ⬆️
packages/immutadot/src/string/padStart.js 100% <100%> (ø) ⬆️
packages/immutadot/src/array/reverse.js 100% <100%> (ø) ⬆️
packages/immutadot/src/string/toLowerCase.js 100% <100%> (ø) ⬆️
packages/immutadot/src/nav/propNav.js 100% <100%> (ø) ⬆️
packages/immutadot/src/string/trim.js 100% <100%> (ø) ⬆️
packages/immutadot/src/nav/finalNav.js 100% <100%> (ø) ⬆️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcb9ea...34b7f72. Read the comment docs.

@nlepage nlepage removed the 🚧 WIP label Dec 4, 2018
frinyvonnick
frinyvonnick previously approved these changes Dec 7, 2018
View reviewed changes
@nlepage nlepage changed the base branch from feature/305 to dev December 10, 2018 09:29
@nlepage nlepage merged commit 17dfa15 into dev Dec 10, 2018
@nlepage nlepage deleted the enhance/304 branch December 10, 2018 09:29
nlepage added a commit that referenced this pull request Jan 22, 2019
@nlepage
♻️ Replace convert by new apply (#319)
ffc9cc0 
* ♻️ Use new core.apply in lang

* ♻️ Use core.apply in object

* ♻️ Use new apply in string

* ♻️ Use core.apply in array

* ♻️ Change applyStringMethod signature

* ⬆️ Upgrade circle CI node version 9 -> 10

* 🔧 Fix immutadot-lodash immutadot peer dependency

* ♻️ Use new apply on part of immutadot-lodash/array

* ♻️ Rewrite convertLodashFp to applyLodashFp using new apply

* ♻️ Use new apply in immutadot-lodash/collection

* ♻️ Use new apply on immutadot-lodash/object

* ♻️ Use new apply on immutadot-lodash/string

* 🔥 Remove core.convert and path namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick left review comments

Assignees

@nlepage nlepage

Labels
🔧 enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlepage @codecov-io @frinyvonnick