Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dist is broken #330

Closed
nlepage opened this issue Jan 22, 2019 · 3 comments
Closed

Dist is broken #330

nlepage opened this issue Jan 22, 2019 · 3 comments
Labels
Milestone

Comments

@nlepage
Copy link
Member

nlepage commented Jan 22, 2019

$ rollup -c config/rollup.js

/home/nico/git/znk/immutadot/packages/immutadot/src/index.js → dist/immutadot.js...
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en#error-this-is-undefined
packages/immutadot-parser/index.js
13:     global.index = mod.exports;
14:   }
15: })(this, function (exports, _consts, _toPath) {
       ^
16:   'use strict';
packages/immutadot-parser/consts.js
11:     global.consts = mod.exports;
12:   }
13: })(this, function (exports, _symbol) {
       ^
14:   'use strict';
[!] Error: 'toPath' is not exported by packages/immutadot-parser/index.js
https://rollupjs.org/guide/en#error-name-is-not-exported-by-module-
packages/immutadot/src/core/apply.js (4:9)
2: import { nav } from 'nav/nav'
3: import { resolveGetter } from './get'
4: import { toPath } from '@immutadot/parser'
            ^
5: 
6: const getResolveArg = lazy => lazy ? resolveGetter : arg => arg
Error: 'toPath' is not exported by packages/immutadot-parser/index.js
    at error (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:3460:30)
    at Module.error (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:13349:9)
    at handleMissingExport (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:13039:21)
    at Module.traceVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:13453:17)
    at ModuleScope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:12726:29)
    at FunctionScope.Scope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:4022:68)
    at Scope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:4022:68)
    at BlockScope.Scope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:4022:68)
    at BlockScope.Scope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:4022:68)
    at FunctionScope.Scope.findVariable (/home/nico/git/znk/immutadot/node_modules/rollup/dist/rollup.js:4022:68)

error Command failed with exit code 1.
@nlepage nlepage added this to the 2.0 milestone Jan 22, 2019
@nlepage
Copy link
Member Author

nlepage commented Jan 22, 2019

Do we keep it ?

@nlepage
Copy link
Member Author

nlepage commented Jan 25, 2019

I'm in favor of removing the dist, what do you think @frinyvonnick ?

@nlepage nlepage modified the milestones: 2.0, Future May 10, 2019
@nlepage
Copy link
Member Author

nlepage commented Jun 4, 2019

No more dist

@nlepage nlepage closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant