Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add step to slice notation #337

Merged
merged 5 commits into from
May 23, 2019
Merged

✨ Add step to slice notation #337

merged 5 commits into from
May 23, 2019

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented May 17, 2019

Issue : fix #295

@nlepage nlepage added this to the 2.0 milestone May 17, 2019
@nlepage nlepage self-assigned this May 17, 2019
frinyvonnick
frinyvonnick previously approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@frinyvonnick frinyvonnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@nlepage nlepage requested a review from frinyvonnick May 23, 2019 06:24
@codecov-io
Copy link

Codecov Report

Merging #337 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #337     +/-   ##
=========================================
+ Coverage   97.32%   97.42%   +0.1%     
=========================================
  Files         110      111      +1     
  Lines         411      427     +16     
  Branches       11       12      +1     
=========================================
+ Hits          400      416     +16     
  Misses         11       11
Impacted Files Coverage Δ
packages/immutadot-parser/src/pathParser.ts 100% <100%> (ø) ⬆️
packages/immutadot-parser/src/sliceStep.ts 100% <100%> (ø)
packages/immutadot-parser/src/path.ts 100% <100%> (ø) ⬆️
packages/immutadot/src/nav/sliceNav.js 97.14% <100%> (+0.98%) ⬆️
packages/immutadot-parser/src/sliceBound.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b808a...b130a24. Read the comment docs.

@nlepage nlepage changed the title Add step to slice notation ✨ Add step to slice notation May 23, 2019
@nlepage nlepage merged commit 3909ad5 into master May 23, 2019
@nlepage nlepage deleted the feature/295 branch May 23, 2019 06:39
@nlepage nlepage mentioned this pull request Jun 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frinyvonnick frinyvonnick frinyvonnick approved these changes

Assignees

@nlepage nlepage

Labels
✨ feature
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Add step to slice notation
3 participants
@nlepage @codecov-io @frinyvonnick