Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guidelines #42

Merged
merged 8 commits into from
Jul 4, 2017
Merged

Contributing guidelines #42

merged 8 commits into from
Jul 4, 2017

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Jul 3, 2017

In addition of the README #1

  • Write contributing guidelines
  • Write code of conduct
  • Write issue template
  • Write pull request template

@nlepage nlepage added this to the 0.2-alpha milestone Jul 3, 2017
@nlepage nlepage self-assigned this Jul 3, 2017
@codecov-io
Copy link

codecov-io commented Jul 3, 2017

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines          36     36           
=====================================
  Hits           36     36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3508bc...59a3ea5. Read the comment docs.

@nlepage nlepage changed the title 🚧 Contributing guidelines 🚧 Contributing guidelines Jul 4, 2017
@nlepage nlepage requested a review from frinyvonnick July 4, 2017 13:02
### Pull requests :arrow_up:
#### Installation :package:
We use [yarn](https://yarnpkg.com/) but you are free to use [npm](https://www.npmjs.com/) if you prefer.<br />
Once you have cloned the project, run `yarn` or `npm install` to install all the dependencies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting to add a package.lock for npm users

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#44 created

@nlepage nlepage merged commit c7a34f3 into master Jul 4, 2017
@nlepage nlepage deleted the doc/contributing branch July 4, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants