Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage lock files more smoothly #86

Closed
2 tasks done
nlepage opened this issue Sep 2, 2017 · 2 comments · Fixed by #126
Closed
2 tasks done

Manage lock files more smoothly #86

nlepage opened this issue Sep 2, 2017 · 2 comments · Fixed by #126

Comments

@nlepage
Copy link
Member

nlepage commented Sep 2, 2017

Prerequisites

Description

We are currently saving both npm 5 and yarn lock files in github.
For sure it is not realistic to ask of contributors to think of updating both these files when adding or upgrading dependencies.
There is currently a discussion at yarnpkg/yarn#3614 about supporting npm 5 package-lock.json, which would be nice...

In the mean time, it seems there is no elegant way of dealing with this.
We could choose to keep only one of the lock files, but we can not make sure that contributors will use npm over yarn or yarn over npm.

Currently npm seems to suffer a minor drawback in comparison to yarn, related to unwanted updates to package-lock.json when switching between Linux (or Windows !) and Mac npm/npm#17722, in particular with fsevents which is a Mac specific dependency.
@frinyvonnick Have you used npm 5 and experienced unwanted package-lock.json updates on the project ?

@nlepage
Copy link
Member Author

nlepage commented Nov 10, 2017

Things are not moving very fast at npm, so for now we'll only support yarn.
package-lock.json will be removed and ignored.

@nlepage nlepage modified the milestones: Future, 0.4-alpha Nov 10, 2017
@nlepage nlepage self-assigned this Nov 10, 2017
@nlepage
Copy link
Member Author

nlepage commented Nov 10, 2017

In addition we'll probably use yarn workspaces with lerna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant