-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string functions #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 59 63 +4
Lines 120 124 +4
Branches 7 7
=====================================
+ Hits 120 124 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add string namespace to ChainWrapper and UsingWrapper
src/string/capitalize.js
Outdated
* @return {Object} Returns the updated object. | ||
* @example capitalize({ nested: { a: "a string" } }, 'nested.a') // => { nested: { a: "A string" } } | ||
* @see {@link https://lodash.com/docs#capitalize|lodash.capitalize} for more information. | ||
* @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this link
src/string/capitalize.spec.js
Outdated
|
||
describe('Capitalize', () => { | ||
|
||
it('should converts the first character of string to upper case and the remaining to lower case', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"should convert ..." -s
src/string/replace.js
Outdated
* @return {Object} Returns the updated object. | ||
* @example replace({ nested: { a: "Hi Nico" } }, 'nested.a', 'Nico', 'Yvo') // => { nested: { a: "Hi Yvo" } } | ||
* @see {@link https://lodash.com/docs#replace|lodash.replace} for more information. | ||
* @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this link
src/string/toLower.js
Outdated
* @return {Object} Returns the updated object. | ||
* @example toLower({ nested: { a: "A STRING" } }, 'nested.a') // => { nested: { a: "a string" } } | ||
* @see {@link https://lodash.com/docs#toLower|lodash.toLower} for more information. | ||
* @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this link
import { convert } from 'util/convert' | ||
|
||
/** | ||
* Converts string, as a whole, to lower case just like String#toLowerCase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to https://mdn.io/String/toLowerCase
src/string/toLower.spec.js
Outdated
|
||
describe('toLower', () => { | ||
|
||
it('should converts string, as a whole, to lower case just like String#toLowerCase', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"should convert" -s
src/string/toUpper.js
Outdated
* @return {Object} Returns the updated object. | ||
* @example toUpper({ nested: { a: "a string" } }, 'nested.a') // => { nested: { a: "A STRING" } } | ||
* @see {@link https://lodash.com/docs#toUpper|lodash.toUpper} for more information. | ||
* @see {@link https://lodash.com/docs#identity|lodash.identity} for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this link
src/string/toUpper.spec.js
Outdated
|
||
describe('toUpper', () => { | ||
|
||
it('should converts string, as a whole, to upper case just like String#toUpperCase', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"should convert" -s
import { convert } from 'util/convert' | ||
|
||
/** | ||
* Converts string, as a whole, to upper case just like String#toUpperCase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to https://mdn.io/String/toUpperCase
* @since 0.3.0 | ||
*/ | ||
export { | ||
capizalize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩
Issue: #79