Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Setup linting and formatting dev tools #4

Merged
merged 11 commits into from May 4, 2022

Conversation

fa9r
Copy link
Contributor

@fa9r fa9r commented May 4, 2022

I setup dev tools for linting and formatting to improve code quality of our .py files.

Changes:

  • Added pyproject.toml that defines all dev tools and their configs. This also enables poetry install to set them up.
  • Added scripts for linting, formatting, and spell-checking in scripts/.
  • Defined pre-commit hooks in .pre-commit-config.yaml that calls linting and spell-checking.
  • Moved all the .py code files into src/ and fixed all linting/formatting issues.

@fa9r fa9r requested a review from htahir1 May 4, 2022 10:01
Copy link

@ayush714 ayush714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really Nice work, It will be also good if you look at adding linting formatting tools in zenfiles as well, nevertheless, let's get this work for zenbytes, then we can take a look later on because it's not urgent.

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but other than that looks good!

02 - Transitioning To Production.ipynb Outdated Show resolved Hide resolved
@fa9r fa9r requested a review from htahir1 May 4, 2022 14:24
@htahir1
Copy link
Contributor

htahir1 commented May 4, 2022

Really awesome job!

@fa9r fa9r merged commit 94f0bdd into main May 4, 2022
@fa9r fa9r deleted the feature/ENG-771-linting-fortmatting-tools branch May 6, 2022 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants