New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Label Studio OCR config generation #1062
Add support for Label Studio OCR config generation #1062
Conversation
Label studio OCR config support
@shivalikasingh95 This is a great contribution and im sure @strickvl will have some thoughts when he seens it. For now, what I can say is that we have one minor docstring quality check that failed
Could you add labels to that docstring? |
If it's not too much of a pain, could you also write a unit test validating the output of the label config utility function you've added? You'll see a template for how to do that exists already in our As for the rest, I'll check it properly in the morning, but it looks great at first glance! |
Sure @htahir1 I'll fix this! |
Sure thing @strickvl! I'd be happy to write the unit test :) Will update the PR shortly! |
@strickvl |
@shivalikasingh95 Thank you! When u hav written the test just ping me and ill merge this! |
@strickvl |
3 similar comments
@strickvl |
@strickvl |
@strickvl |
@strickvl |
5 similar comments
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
7 similar comments
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
@strickvl |
2 similar comments
@strickvl |
@strickvl |
Hi @htahir1 and @strickvl just a gentle reminder to do a quick review of the PR whenever you guys find the time :) |
@strickvl |
@shivalikasingh95 Sorry for the delay here. @strickvl is the only one who can validate the test and hes on vacation and only back in a few days. We will take a look and merge this week! |
@strickvl |
@htahir1 No problem, thanks for the update! I just thought of checking once from my end. Will wait for @strickvl to get back :) No worries! |
@strickvl |
@strickvl |
@strickvl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, and for adding in the tests. This looks good to me and I'll get it merged in now.
@shivalikasingh95 for the other suggested contributions, points 1 and 2 would probably be best to start with right now. The third one will also be welcomed, but it might interact or be improved by something else that's changing in the codebase right now so maybe give it a couple of weeks before you take a look at that. Some of the Label Studio config auto-generation might be a bit more tricky, however, so feel free to check in with us if you have any questions. Just try to be as generic as possible and you should be fine. |
@shivalikasingh95 Thank you for your contribution! I have posted about it here: https://www.linkedin.com/posts/hamzatahirofficial_mlops-activity-7010547706611834881-2_37?utm_source=share&utm_medium=member_desktop :-) Again congrats on your awesome submission! |
Describe changes
Hi, as part of the MLOps competition, I wanted to use Label Studio for OCR labelling task. Since ZenML currently supports only generation of template for image classification and object detection labelling tasks, I implemented support for OCR to support my use case. I thought of contributing this back since it might be useful for others too.
As a user of zenml, I felt that all the features supported by label studio should be accessible via the zenml integration as well. So I'd be happy to submit a similar PR to support other kinds of labelling tasks supported by label studio if you guys would be interested in it.
Do let me know if the current PR requires any changes.
Pre-requisites
Please ensure you have done the following:
Types of changes