New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for io_utils
and removal of duplicate code
#1199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, always happy to get rid of unused/duplicate code 😊
New tests all look good. Only question: what happened to the is_remote
tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Felix Altenberger <felix@zenml.io>
@bcdurak As discussed, I moved things back such that fileio is the core selection of filesystem functions, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strickvl Looks great! Amazing job with the tests as well!
Tests for the methods inside
io_utils
and a couple of places where I thought the original source needed small changes.Found some duplicate code which existed inside fileio as well as in io_utils so I removed it, leaving
fileio.py
as the canonical place for most of those kinds of functions.Pre-requisites
Please ensure you have done the following:
Types of changes