Tests for network_utils
#1201
Merged
Tests for network_utils
#1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
added
internal
fa9r
approved these changes
Dec 22, 2022
Co-authored-by: Felix Altenberger <felix@zenml.io>
Co-authored-by: Felix Altenberger <felix@zenml.io>
Co-authored-by: Felix Altenberger <felix@zenml.io>
stefannica
requested changes
Jan 11, 2023
Co-authored-by: Stefan Nica <stefan@zenml.io>
stefannica
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the
network_utilscode.Wasn't fully sure of the best way to test this kind of network calls / scans, so happy to rework following any feedback that might come my way.
Pre-requisites
Please ensure you have done the following:
Types of changes