Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for Hyperparameter Tuning with ZenML #1206

Merged
merged 9 commits into from Feb 3, 2023
Merged

Add example for Hyperparameter Tuning with ZenML #1206

merged 9 commits into from Feb 3, 2023

Conversation

nitay93
Copy link
Contributor

@nitay93 nitay93 commented Jan 1, 2023

Describe changes

I implemented a hyperparameter tuning pipeline example.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@CLAassistant
Copy link

CLAassistant commented Jan 1, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@nitay93 nitay93 force-pushed the feature/hyperparameter-tuning-example branch 2 times, most recently from f3dae1f to 3a958d2 Compare January 1, 2023 14:08
@nitay93 nitay93 force-pushed the feature/hyperparameter-tuning-example branch from 3a958d2 to 403cc79 Compare January 1, 2023 14:19
@schustmi schustmi self-requested a review January 12, 2023 15:41
@htahir1
Copy link
Contributor

htahir1 commented Jan 12, 2023

@nitay93 Sorry for the delay on reviewing this. @schustmi is now back and will send you a review! Thank you again!

@strickvl strickvl added the enhancement New feature or request label Jan 12, 2023
htahir1
htahir1 requested changes Jan 12, 2023
View reviewed changes
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
schustmi
schustmi requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nitay93, this is a great example of your dynamic pipeline!

It would be nice if you could add the license to the top of all python files (you can just copy it from any other file in this repo), but other than that I didn't have any major complaints regarding the code

examples/hyperparameter_tuning/steps/evaluation/compare_scores.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
bcdurak
bcdurak requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you so much for this PR @nitay93.

Regarding ML workflows, hyperparameter tuning is an important topic, and enabling it may become quite crucial in certain scenarios. Moreover, this PR also brings the ability to create dynamic pipelines which are quite impressive.

I have had some previous discussions with @schustmi and looked over the code. I have left some comments as well.

examples/hyperparameter_tuning/dynamic_pipelines/dynamic_pipeline.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/pipelines/hyperparameter_tuning.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/pipelines/hyperparameter_tuning.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/dynamic_pipelines/gather_step.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/dynamic_pipelines/gather_step.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/dynamic_pipelines/dynamic_pipeline.py Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/README.md Outdated Show resolved Hide resolved
examples/hyperparameter_tuning/steps/evaluation/compare_scores.py Outdated Show resolved Hide resolved
@nitay93 @htahir1
@schustmi @bcdurak
Hyperparameter tuning example - apply README and docstring PR suggest…
5af9a0b 
…ions

Co-authored-by: Hamza Tahir <hamza@zenml.io>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Co-authored-by: Barış Can Durak <36421093+bcdurak@users.noreply.github.com>
@nitay93 nitay93 force-pushed the feature/hyperparameter-tuning-example branch from 5c97ce1 to 5af9a0b Compare January 22, 2023 09:56
@nitay93 nitay93 requested review from htahir1, schustmi and bcdurak and removed request for htahir1, schustmi and bcdurak January 26, 2023 08:51
@htahir1
Copy link
Contributor

htahir1 commented Jan 26, 2023

@nitay93 Fantastic job! All good from my side, just waiting for @schustmi and then we merge it

@schustmi schustmi merged commit 7a85f2d into zenml-io:develop Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@schustmi schustmi schustmi approved these changes

@bcdurak bcdurak bcdurak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nitay93 @CLAassistant @htahir1 @schustmi @bcdurak @strickvl