Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Distribute requirements.txt into folder wise structure #80

Closed
ramitsurana opened this issue Apr 26, 2021 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@ramitsurana
Copy link
Contributor

Is your enhancement request related to a problem? Please describe.
No

Describe the enhancement you'd like
I was going through this File and wanted to check your thoughts if we could create a folder wise tree-like structure for different requirements like extensions, providers etc. in text files, depending on our use case and refer to the path of the requirements files from contants.py. Let me know if you see any challenges. For Example -

requirements
-> base.txt
-> providers
    -> gcp.txt
    -> azure.txt
    -> aws.txt
-> datasources
    -> huggingface.txt

How do you solve your current problem with the current status-quo of ZenML?
It would make it easier to update and maintain the versions of dependencies including extensions, base dependencies etc rather than updating the python file for any version updates.

Additional context
enhance

@ramitsurana ramitsurana added the enhancement New feature or request label Apr 26, 2021
@bcdurak
Copy link
Contributor

bcdurak commented Apr 26, 2021

Hey @ramitsurana , thank you for opening this issue.

The integrations are an essential part of ZenML and it is definitely important to keep the requirements of each integration as organized as possible. However, with the increasing number of integrations, it will become more and more challenging to place them in clear-cut categories. Huggingface is a great example of this particular problem because we use it both as a datasource and as a training integration. That is why we opted to keep the requirements in a single central file.

@ramitsurana
Copy link
Contributor Author

@bcdurak Cool. Makes Sense. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants