Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloaded SubPort operations will have unexpected behaviour #30

Open
zenna opened this issue Sep 21, 2017 · 0 comments
Open

Overloaded SubPort operations will have unexpected behaviour #30

zenna opened this issue Sep 21, 2017 · 0 comments
Labels

Comments

@zenna
Copy link
Owner

zenna commented Sep 21, 2017

Currently if you do x + y where x and y are subports, a new AddArrow will be created and added to the parent composition of x and y, and links will be made from x and y to the in_ports of the subarrow.

However, there are several cases we haven't accounted for which will simply break or give undesired or unexpected behaviour:

  • x and y have different parents, should this be an undefined operation or should we attempt a kind of merge
  • x or y are dst SubPorts rather than src. Should this be undefined or should we go back to the source. Should we delete the current edge
@zenna zenna added the bug label Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant