New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.0.6 #6
v0.0.6 #6
Conversation
This reverts commit 6215b6c.
Fix: invalid plasma.cancel return statement
I've read through the code for:
Each repo looks clean and ready for testing. Thank you for all the effort you put into this. |
…_cli_dart into feature/ledger
Added docs for ledger and devnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I don't have a Ledger device, so I was unable to test the Ledger wallet functionality, but the Ledger related implementations look fine.
I've ordered a ledger and hope to test this week. |
This PR adds support for the following:
Limitations
wallet.createNew
,wallet.createFromMnemonic
,wallet.dumpMnemonic
,wallet.export
.Tests
Known issues
LedgerTransport
throws aResponseError
when it detects invalid responses, but sometimes the response is valid but contains old data from memory. This can cause a Ledger command to return but with old data. The Ledger device is never actually called and in case of asignTx
command no confirmation is asked. This issue will eventually cause an exception (for example when signing a transaction) and can only happen when creating multiple connections to the ledger.Notes