Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.6 #6

Merged
merged 61 commits into from Mar 5, 2024
Merged

v0.0.6 #6

merged 61 commits into from Mar 5, 2024

Conversation

KingGorrin
Copy link
Collaborator

@KingGorrin KingGorrin commented Nov 25, 2023

This PR adds support for the following:

  • Added support for Ledger wallets
  • Added Zenon Ledger Wallet library
  • Updated Zenon SDK to v0.0.6 with wallet abstraction support
  • Updated library builder workflow to include Ledger FFI binaries

Limitations

  • The following commands are not supported on Ledger wallets: wallet.createNew, wallet.createFromMnemonic, wallet.dumpMnemonic, wallet.export.

Tests

Known issues

  • A Ledger connection becomes invalid when another process opens a new connection to the Ledger. The invalid connection still responds to Ledger commands. The LedgerTransport throws a ResponseError when it detects invalid responses, but sometimes the response is valid but contains old data from memory. This can cause a Ledger command to return but with old data. The Ledger device is never actually called and in case of a signTx command no confirmation is asked. This issue will eventually cause an exception (for example when signing a transaction) and can only happen when creating multiple connections to the ledger.

Notes

  • All hypercore-one references will be updated and moved to zenon-network once reviewed and approved.

@KingGorrin KingGorrin added the enhancement New feature or request label Nov 25, 2023
@KingGorrin KingGorrin self-assigned this Nov 25, 2023
@KingGorrin KingGorrin marked this pull request as ready for review November 25, 2023 22:41
@sol-znn
Copy link
Collaborator

sol-znn commented Nov 25, 2023

I've read through the code for:

  • znn_cli_dart v0.0.6
  • znn_ledger_dart
  • ledger_ffi_rs

Each repo looks clean and ready for testing. Thank you for all the effort you put into this.
Unfortunately, my scope of testing will be limited since I don't have a Ledger device.
If another maintainer can confirm the code is working as expected, I'll add my approval.

@KingGorrin
Copy link
Collaborator Author

Added docs for ledger and devnet.
Added tests and test runs from znn_cli_dart-manual-tests.
Updated sdk and ledger references.
Fixed token max supply limit.

Copy link
Collaborator

@vilkris4 vilkris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I don't have a Ledger device, so I was unable to test the Ledger wallet functionality, but the Ledger related implementations look fine.

@0x3639
Copy link
Collaborator

0x3639 commented Feb 11, 2024

I've ordered a ledger and hope to test this week.

@KingGorrin KingGorrin mentioned this pull request Feb 26, 2024
@KingGorrin KingGorrin merged commit fee4a84 into zenon-network:master Mar 5, 2024
@KingGorrin KingGorrin deleted the feature/ledger branch March 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants