Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack build breaks #6

Closed
calebmer opened this issue Nov 26, 2015 · 3 comments
Closed

Webpack build breaks #6

calebmer opened this issue Nov 26, 2015 · 3 comments

Comments

@calebmer
Copy link

Because the require keyword is present in zen-observable.js as a parameter, webpack tries to bundle all of the files in the root folder. Could the project be changed do maybe instead of calling the variable require instead call it requireFn? That way require can be used in the way which build tools like webpack expect.
@calebmer
Copy link
Author

Turns out require is actually needed in a node environment, I thought it was just a syntax sugar thing. Because it's not used maybe require can just be removed entirely?

@zenparsing
Copy link
Owner

Thanks @calebmer, will take a look and get it working!

@zenparsing
Copy link
Owner

Should be fixed now in 0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenparsing @calebmer